Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c

From	Tony Jones <tonyj@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c
Date	2017-04-24 17:50 +0200
Message-ID	<tzOpr-mK-3@gated-at.bofh.it> (permalink)
References	<tzDNo-21u-3@gated-at.bofh.it> <tzLUC-7pd-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/24/2017 06:05 AM, Andi Kleen wrote:
> On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote:
>> Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent 
>> possible redefinition error.
> 
> Who defines it? 
> 
> If it's always defined somewhere else it can be just removed.
> 
> -Andi

sometimes it's defaulted on (I believe) by the toolchain.    it fails on our SLE12-SP3 toolchain.
I assumed the existing guard in pt-decoder/intel-pt-decoder.c (only other use) was for a reason.

tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Tony Jones <tonyj@suse.de> - 2017-04-24 06:30 +0200
  [PATCH 2/2] perf tools: Add NULL end elements to 'unit_to_pmu' map Tony Jones <tonyj@suse.de> - 2017-04-24 06:30 +0200
  Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Andi Kleen <ak@linux.intel.com> - 2017-04-24 15:10 +0200
    Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Tony Jones <tonyj@suse.de> - 2017-04-24 17:50 +0200

csiph-web