Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629520
| From | Andi Kleen <ak@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c |
| Date | 2017-04-24 15:10 +0200 |
| Message-ID | <tzLUC-7pd-7@gated-at.bofh.it> (permalink) |
| References | <tzDNo-21u-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote: > Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent > possible redefinition error. Who defines it? If it's always defined somewhere else it can be just removed. -Andi > > Signed-off-by: Tony Jones <tonyj@suse.de> > --- > tools/perf/pmu-events/jevents.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > index baa073f38334..b6300e875b87 100644 > --- a/tools/perf/pmu-events/jevents.c > +++ b/tools/perf/pmu-events/jevents.c > @@ -1,5 +1,7 @@ > #define _XOPEN_SOURCE 500 /* needed for nftw() */ > +#ifndef _GNU_SOURCE > #define _GNU_SOURCE /* needed for asprintf() */ > +#endif > > /* Parse event JSON files */ > > -- > 2.11.0 >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Tony Jones <tonyj@suse.de> - 2017-04-24 06:30 +0200
[PATCH 2/2] perf tools: Add NULL end elements to 'unit_to_pmu' map Tony Jones <tonyj@suse.de> - 2017-04-24 06:30 +0200
Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Andi Kleen <ak@linux.intel.com> - 2017-04-24 15:10 +0200
Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Tony Jones <tonyj@suse.de> - 2017-04-24 17:50 +0200
csiph-web