Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629682

Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

Show all headers | View raw

On Mon, 24 Apr 2017 12:14:14 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure
> <jeremy.lefaure@lse.epita.fr> wrote:
> > The cpufv sysfs file is defined as readable by anyone even if the
> > attribute does not have a show function. The result of every read is an
> > IO error. This file should be write only.  
> 
> Per se patch looks good to me, though would be better to add show()
> hook as well?
> 
It depends if we want to keep it write-only as it is documented in
Documentation/ABI/testing/sysfs-platform-asus-wmi.

If we want to have this file read/write, I can send a v2 of this patch.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Jérémy Lefaure          <jeremy.lefaure@lse.epita.fr> - 2017-04-22 04:30 +0200
  Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 11:20 +0200
    Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> - 2017-04-24 17:40 +0200
      Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-25 14:30 +0200

csiph-web