Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission
Date	2017-04-25 14:30 +0200
Message-ID	<tA7Ls-4EF-33@gated-at.bofh.it> (permalink)
References	<tySYa-5pV-3@gated-at.bofh.it> <tzIk2-59r-9@gated-at.bofh.it> <tzOfL-hH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 24, 2017 at 6:31 PM, Jérémy Lefaure
<jeremy.lefaure@lse.epita.fr> wrote:
> On Mon, 24 Apr 2017 12:14:14 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
>> On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure
>> <jeremy.lefaure@lse.epita.fr> wrote:
>> > The cpufv sysfs file is defined as readable by anyone even if the
>> > attribute does not have a show function. The result of every read is an
>> > IO error. This file should be write only.
>>
>> Per se patch looks good to me, though would be better to add show()
>> hook as well?
>>
> It depends if we want to keep it write-only as it is documented in
> Documentation/ABI/testing/sysfs-platform-asus-wmi.
>
> If we want to have this file read/write, I can send a v2 of this patch.

I dunno we need.
So, since no answer from anyone I pushed this to testing, thanks!

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Jérémy Lefaure          <jeremy.lefaure@lse.epita.fr> - 2017-04-22 04:30 +0200
  Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 11:20 +0200
    Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> - 2017-04-24 17:40 +0200
      Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-25 14:30 +0200

csiph-web