Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629508

Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in arizona_extcon_get_micd_configs()

Show all headers | View raw

On Mon, Apr 24, 2017 at 02:43:55PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 23 Apr 2017 22:44:19 +0200
> 
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "devm_kcalloc".
> 
> * Replace the specification of a data structure by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Actually fixes a bug on the alloc as well looks like the type was
wrong before.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Extcon: Fine-tuning for three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:40 +0200
  [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:50 +0200
    Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-04-24 15:00 +0200
      Re: extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 15:40 +0200
        Re: extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-04-26 10:10 +0200
  [PATCH 1/3] extcon: Use devm_kcalloc() in extcon_dev_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:50 +0200
  [PATCH 2/3] extcon: Fix a typo in three comment lines SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:50 +0200

csiph-web