Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629494

[PATCH 3/3] extcon: arizona: Use devm_kcalloc() in arizona_extcon_get_micd_configs()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 23 Apr 2017 22:44:19 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/extcon/extcon-arizona.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index e2d78cd7030d..f84da4a17724 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -1271,9 +1271,7 @@ static int arizona_extcon_get_micd_configs(struct device *dev,
 		goto out;
 
 	nconfs /= entries_per_config;
-
-	micd_configs = devm_kzalloc(dev,
-				    nconfs * sizeof(struct arizona_micd_range),
+	micd_configs = devm_kcalloc(dev, nconfs, sizeof(*micd_configs),
 				    GFP_KERNEL);
 	if (!micd_configs) {
 		ret = -ENOMEM;
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Extcon: Fine-tuning for three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:40 +0200
  [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:50 +0200
    Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-04-24 15:00 +0200
      Re: extcon: arizona: Use devm_kcalloc() in  arizona_extcon_get_micd_configs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 15:40 +0200
  [PATCH 1/3] extcon: Use devm_kcalloc() in extcon_dev_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:50 +0200
  [PATCH 2/3] extcon: Fix a typo in three comment lines SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-24 14:50 +0200

csiph-web