[PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify()

From	NeilBrown <neilb@suse.com>
Newsgroups	linux.kernel
Subject	[PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify()
Date	2017-04-20 07:50 +0200
Message-ID	<tyd8D-4Wq-35@gated-at.bofh.it> (permalink)
References	<tyd8C-4Wq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This function allocates a bio, then a collection
of pages.  It copes with failure.

It currently uses a mempool() to allocate the bio,
but alloc_page() to allocate the pages.  These fail
in different ways, so the usage is inconsistent.

Change the bio_clone() to bio_clone_kmalloc()
so that no pool is used either for the bio or the pages.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/md/bcache/debug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
index 06f55056aaae..35a5a7210e51 100644
--- a/drivers/md/bcache/debug.c
+++ b/drivers/md/bcache/debug.c
@@ -110,7 +110,7 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio)
 	struct bio_vec bv, cbv;
 	struct bvec_iter iter, citer = { 0 };
 
-	check = bio_clone(bio, GFP_NOIO);
+	check = bio_clone_kmalloc(bio, GFP_NOIO);
 	if (!check)
 		return;
 	check->bi_opf = REQ_OP_READ;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 09/11] bcache: use kmalloc to allocate bio in  bch_data_verify() NeilBrown <neilb@suse.com> - 2017-04-20 07:50 +0200
  Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in  bch_data_verify() Kent Overstreet <kent.overstreet@gmail.com> - 2017-04-21 13:40 +0200
  Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in  bch_data_verify() Christoph Hellwig <hch@infradead.org> - 2017-04-21 13:40 +0200
  Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify() Ming Lei <tom.leiming@gmail.com> - 2017-04-21 20:40 +0200

csiph-web