Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify()

From	Ming Lei <tom.leiming@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify()
Date	2017-04-21 20:40 +0200
Message-ID	<tyLDk-LM-31@gated-at.bofh.it> (permalink)
References	<tyd8C-4Wq-7@gated-at.bofh.it> <tyd8D-4Wq-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown <neilb@suse.com> wrote:
> This function allocates a bio, then a collection
> of pages.  It copes with failure.
>
> It currently uses a mempool() to allocate the bio,
> but alloc_page() to allocate the pages.  These fail
> in different ways, so the usage is inconsistent.
>
> Change the bio_clone() to bio_clone_kmalloc()
> so that no pool is used either for the bio or the pages.
>
> Signed-off-by: NeilBrown <neilb@suse.com>

Reviewed-by : Ming Lei <ming.lei@redhat.com>


Thanks,
Ming Lei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 09/11] bcache: use kmalloc to allocate bio in  bch_data_verify() NeilBrown <neilb@suse.com> - 2017-04-20 07:50 +0200
  Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in  bch_data_verify() Kent Overstreet <kent.overstreet@gmail.com> - 2017-04-21 13:40 +0200
  Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in  bch_data_verify() Christoph Hellwig <hch@infradead.org> - 2017-04-21 13:40 +0200
  Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify() Ming Lei <tom.leiming@gmail.com> - 2017-04-21 20:40 +0200

csiph-web