Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628810
| From | Javier González <jg@lightnvm.io> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() |
| Date | 2017-04-22 11:20 +0200 |
| Message-ID | <tyZmV-Zm-3@gated-at.bofh.it> (permalink) |
| References | <tyd8C-4Wq-7@gated-at.bofh.it> <tydii-4ZP-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
> On 20 Apr 2017, at 07.38, NeilBrown <neilb@suse.com> wrote: > > blk_queue_split() is always called with the last arg being q->bio_split, > where 'q' is the first arg. > > Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses > q->bio_split. > > This is inconsistent and unnecessary. Remove the last arg and always use > q->bio_split inside blk_queue_split() > > Signed-off-by: NeilBrown <neilb@suse.com> > --- > block/blk-core.c | 2 +- > block/blk-merge.c | 9 ++++----- > block/blk-mq.c | 2 +- > drivers/block/drbd/drbd_req.c | 2 +- > drivers/block/pktcdvd.c | 2 +- > drivers/block/ps3vram.c | 2 +- > drivers/block/rsxx/dev.c | 2 +- > drivers/block/umem.c | 2 +- > drivers/block/zram/zram_drv.c | 2 +- > drivers/lightnvm/rrpc.c | 2 +- > drivers/md/md.c | 2 +- > drivers/s390/block/dcssblk.c | 2 +- > drivers/s390/block/xpram.c | 2 +- > include/linux/blkdev.h | 3 +-- > 14 files changed, 17 insertions(+), 19 deletions(-) > It most probably made it to Jens' tree after you made these changes, but in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a couple of places inside pblk_rw_io(). Thanks, Javier.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/11] blk: remove bio_set arg from blk_queue_split() NeilBrown <neilb@suse.com> - 2017-04-20 08:00 +0200
Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() Christoph Hellwig <hch@infradead.org> - 2017-04-21 13:30 +0200
Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() Ming Lei <tom.leiming@gmail.com> - 2017-04-21 17:30 +0200
Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() Javier González <jg@lightnvm.io> - 2017-04-22 11:20 +0200
Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() NeilBrown <neilb@suse.com> - 2017-04-24 04:40 +0200
csiph-web