Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1628356

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

From Ming Lei <tom.leiming@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()
Date 2017-04-21 17:30 +0200
Message-ID <tyIFs-7rg-11@gated-at.bofh.it> (permalink)
References <tyd8C-4Wq-7@gated-at.bofh.it> <tydii-4ZP-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown <neilb@suse.com> wrote:
> blk_queue_split() is always called with the last arg being q->bio_split,
> where 'q' is the first arg.
>
> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
> q->bio_split.
>
> This is inconsistent and unnecessary.  Remove the last arg and always use
> q->bio_split inside blk_queue_split()
>
> Signed-off-by: NeilBrown <neilb@suse.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 01/11] blk: remove bio_set arg from blk_queue_split() NeilBrown <neilb@suse.com> - 2017-04-20 08:00 +0200
  Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() Christoph Hellwig <hch@infradead.org> - 2017-04-21 13:30 +0200
  Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() Ming Lei <tom.leiming@gmail.com> - 2017-04-21 17:30 +0200
  Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() Javier González <jg@lightnvm.io> - 2017-04-22 11:20 +0200
    Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() NeilBrown <neilb@suse.com> - 2017-04-24 04:40 +0200

csiph-web