Re: [PATCH] ARM: omap2+: make omap4_get_cpu1_ns_pa_addr declaration usable

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: omap2+: make omap4_get_cpu1_ns_pa_addr declaration usable
Date	2017-04-22 00:30 +0200
Message-ID	<tyPdU-31Y-3@gated-at.bofh.it> (permalink)
References	<tyOKS-2xl-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Arnd Bergmann <arnd@arndb.de> [170421 14:59]:
> When CONFIG_PM is disabled, we get a build error:
> 
> arch/arm/mach-omap2/omap-smp.c: In function 'omap4_smp_maybe_reset_cpu1':
> arch/arm/mach-omap2/omap-smp.c:309:20: error: implicit declaration of function 'omap4_get_cpu1_ns_pa_addr'; did you mean 'omap4_get_scu_base'? [-Werror=implicit-function-declaration]
> 
> We need to fix this in multiple files, to ensure the declaration is visible,
> to actually build the function without CONFIG_PM, and to only call it
> when OMAP4 and/or OMAP5 are enabled.
> 
> Fixes: 351b7c490700 ("ARM: omap2+: Revert omap-smp.c changes resetting CPU1 during boot")

Oops, sorry about that. Looks like I never hit that with my
randconfig builds earlier probably as we have at least CPU_IDLE and
ARCH_OMAP2PLUS_TYPICAL select PM. Thanks for fixing it:

Acked-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: omap2+: make omap4_get_cpu1_ns_pa_addr declaration usable Arnd Bergmann <arnd@arndb.de> - 2017-04-22 00:00 +0200
  Re: [PATCH] ARM: omap2+: make omap4_get_cpu1_ns_pa_addr declaration  usable Tony Lindgren <tony@atomide.com> - 2017-04-22 00:30 +0200

csiph-web