Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628650

[PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd)

Show all headers | View raw

I don't think the patch is correct, so I haven't bothered signing off on
it.  Probably the & is not correct in the IS_ERR call?

julia

---------- Forwarded message ----------
Date: Sat, 22 Apr 2017 06:09:26 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Simon Ho <simon.ho@conexant.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 cx2072x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/soc/codecs/cx2072x.c
+++ b/sound/soc/codecs/cx2072x.c
@@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_
 		&cx2072x_regmap);

 	if (IS_ERR(&cx2072x->regmap)) {
-		ret = PTR_ERR(cx2072x->regmap);
+		ret = PTR_ERR(&cx2072x->regmap);
 		dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret);
 		return ret;
 	}

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd) Julia Lawall <julia.lawall@lip6.fr> - 2017-04-22 00:20 +0200
  Re: [PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd) Takashi Iwai <tiwai@suse.de> - 2017-04-22 09:00 +0200
    Re: [alsa-devel] [PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd) Simon Ho <simon.ho.cnxt@gmail.com> - 2017-04-24 19:10 +0200

csiph-web