Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628097
| From | luca abeni <luca.abeni@santannapisa.it> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] sched/deadline: fix switching to -deadline |
| Date | 2017-04-21 12:00 +0200 |
| Message-ID | <tyDw5-4fF-13@gated-at.bofh.it> (permalink) |
| References | <tyq5Q-4y2-11@gated-at.bofh.it> <tyDmq-4ci-23@gated-at.bofh.it> <tyDmq-4ci-27@gated-at.bofh.it> |
| Organization | Scuola Superiore S.Anna |
On Fri, 21 Apr 2017 11:42:40 +0200
luca abeni <luca.abeni@santannapisa.it> wrote:
[...]
> > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > > index a2ce590..ec53d24 100644
> > > --- a/kernel/sched/deadline.c
> > > +++ b/kernel/sched/deadline.c
> > > @@ -950,6 +950,10 @@ enqueue_dl_entity(struct sched_dl_entity
> > > *dl_se, update_dl_entity(dl_se, pi_se);
> > > else if (flags & ENQUEUE_REPLENISH)
> > > replenish_dl_entity(dl_se, pi_se);
> > > + else if ((flags & ENQUEUE_RESTORE) &&
> >
> > Not sure I understand how this works. AFAICT we are doing
> > __sched_setscheduler() when we want to catch the case of a new
> > dl_entity (SCHED_{OTHER,FIFO} -> SCHED_DEADLINE}, but queue_flags
> > (which are passed to enqueue_task()) don't seem to have
> > ENQUEUE_RESTORE set?
>
> I was under the impression sched_setscheduler() sets
> ENQUEUE_RESTORE...
__sched_setscheduler() sets queue_flags to DEQUEUE_SAVE, which matches
ENQUEUE_RESTORE (see comments in sched/sched.h), so things should work
correctly, right?
Luca
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-20 21:40 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-21 11:50 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-21 11:50 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 12:00 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Peter Zijlstra <peterz@infradead.org> - 2017-04-21 12:20 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-21 12:30 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 21:10 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-24 12:20 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Luca Abeni <luca.abeni@santannapisa.it> - 2017-04-24 12:40 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-24 13:00 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Peter Zijlstra <peterz@infradead.org> - 2017-04-21 12:20 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 11:50 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 12:00 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Steven Rostedt <rostedt@goodmis.org> - 2017-04-21 15:50 +0200
csiph-web