Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628114
| From | Juri Lelli <juri.lelli@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] sched/deadline: fix switching to -deadline |
| Date | 2017-04-21 12:30 +0200 |
| Message-ID | <tyDZ8-4E7-1@gated-at.bofh.it> (permalink) |
| References | <tyq5Q-4y2-11@gated-at.bofh.it> <tyDmq-4ci-23@gated-at.bofh.it> <tyDmq-4ci-27@gated-at.bofh.it> <tyDmq-4ci-25@gated-at.bofh.it> <tyDw5-4fF-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 21/04/17 11:59, Luca Abeni wrote:
> On Fri, 21 Apr 2017 10:47:29 +0100
> Juri Lelli <juri.lelli@arm.com> wrote:
> [...]
> > > > > *dl_se, update_dl_entity(dl_se, pi_se);
> > > > > else if (flags & ENQUEUE_REPLENISH)
> > > > > replenish_dl_entity(dl_se, pi_se);
> > > > > + else if ((flags & ENQUEUE_RESTORE) &&
> > > >
> > > > Not sure I understand how this works. AFAICT we are doing
> > > > __sched_setscheduler() when we want to catch the case of a new
> > > > dl_entity (SCHED_{OTHER,FIFO} -> SCHED_DEADLINE}, but queue_flags
> > > > (which are passed to enqueue_task()) don't seem to have
> > > > ENQUEUE_RESTORE set?
> > >
> > > I was under the impression sched_setscheduler() sets
> > > ENQUEUE_RESTORE...
> >
> > Oh, I think it works "by coincidence", as ENQUEUE_RESTORE ==
> > DEQUEUE_SAVE == 0x02 ? :)
>
> Not sure if this is a conincidence... By looking at the comments in
> sched/sched.h I got the impression the two values match by design (and
> __sched_setscheduler() is using this property to simplify the code :)
>
Yep, right.
Do you think we might get into trouble with do_set_cpus_allowed()?
Can it happen that we change a task affinity while its deadline is in
the past?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-20 21:40 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-21 11:50 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-21 11:50 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 12:00 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Peter Zijlstra <peterz@infradead.org> - 2017-04-21 12:20 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-21 12:30 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 21:10 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-24 12:20 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Luca Abeni <luca.abeni@santannapisa.it> - 2017-04-24 12:40 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Juri Lelli <juri.lelli@arm.com> - 2017-04-24 13:00 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Peter Zijlstra <peterz@infradead.org> - 2017-04-21 12:20 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 11:50 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline luca abeni <luca.abeni@santannapisa.it> - 2017-04-21 12:00 +0200
Re: [PATCH] sched/deadline: fix switching to -deadline Steven Rostedt <rostedt@goodmis.org> - 2017-04-21 15:50 +0200
csiph-web