Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628048

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

Show all headers | View raw

On Fri, Apr 21, 2017 at 09:34:18AM +0100, John Garry wrote:
> Thanks Johannes.
> 
> @wangyijing, can you test this patchset please (specifically 3/5)? I know
> that you have the modified version of libsas which you dabbled with
> upstreaming.
> 
> On 21/04/2017 09:04, Johannes Thumshirn wrote:
> >This series re-orders the calls to scsi_remove_host() and sas_remove_host() in
> >all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is
> >for two reasons:
> >	1) After the change to recursive removal of sysfs entries, we're
> >	   trying to remove already removed kobjects when doing a
> >	   sas_remove_host() _after_ a scsi_remove_host()
> >	2) the documentation mandates it even (becuase of 1)
> >
> >Unfortunately this does not completely solve issues with recursive sysfs
> >removals in SAS, as libsas has asynchronous behaviour where strong ordering
> >would be needed. But I am working on it and I do know other do as well. So if
> >anyone else (James, Christoph, Bart, I'm looking at you) has an idea, I do
> >have test setups and I'm willing to take input in form of ideas and patches.
> >
> 
> wangyijing already sent an RFC for fixing this issue (mentioned above),
> which was a signifiagnt rewrite of some of libsas.
> I am hoping that he would retry, and that community would support/shepherd
> this activity, or at least say it will be accepted so effort is not wasted.

Do you have a link to the series? No problem if not, I'll probably can find it
in my archives. Anyways, if Wangyijing is re-sending his patches please Cc me
on it.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 10:10 +0200
  [PATCH v2 5/5] scsi: pm8001: remove the SAS host after the SCSI host Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 10:10 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 10:40 +0200
    Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs John Garry <john.garry@huawei.com> - 2017-04-21 11:00 +0200
      Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host         in SAS HBA LLDDs Christoph Hellwig <hch@lst.de> - 2017-04-21 13:30 +0200
        Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs John Garry <john.garry@huawei.com> - 2017-04-21 14:00 +0200
          Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs wangyijing <wangyijing@huawei.com> - 2017-04-22 02:50 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs John Garry <john.garry@huawei.com> - 2017-04-21 10:40 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 13:30 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host         in SAS HBA LLDDs Christoph Hellwig <hch@lst.de> - 2017-04-21 13:30 +0200

csiph-web