Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628031

[PATCH v2 5/5] scsi: pm8001: remove the SAS host after the SCSI host

Show all headers | View raw

After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
removal path of kernfs to make it recursive we have to remove the SAS host
before the SCSI host or we will see sysfs warnings on not found sysfs groups for
kobjects.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/pm8001/pm8001_init.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 417368ccb686..e8f3d5ada201 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -1086,11 +1086,15 @@ static void pm8001_pci_remove(struct pci_dev *pdev)
 {
 	struct sas_ha_struct *sha = pci_get_drvdata(pdev);
 	struct pm8001_hba_info *pm8001_ha;
+	struct Scsi_Host *shost;
 	int i, j;
 	pm8001_ha = sha->lldd_ha;
-	scsi_remove_host(pm8001_ha->shost);
+	shost = pm8001_ha->shost;
+
 	sas_unregister_ha(sha);
-	sas_remove_host(pm8001_ha->shost);
+	sas_remove_host(shost);
+	scsi_remove_host(shost);
+
 	list_del(&pm8001_ha->list);
 	PM8001_CHIP_DISP->interrupt_disable(pm8001_ha, 0xFF);
 	PM8001_CHIP_DISP->chip_soft_rst(pm8001_ha);
-- 
2.12.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 10:10 +0200
  [PATCH v2 5/5] scsi: pm8001: remove the SAS host after the SCSI host Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 10:10 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 10:40 +0200
    Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs John Garry <john.garry@huawei.com> - 2017-04-21 11:00 +0200
      Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host         in SAS HBA LLDDs Christoph Hellwig <hch@lst.de> - 2017-04-21 13:30 +0200
        Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs John Garry <john.garry@huawei.com> - 2017-04-21 14:00 +0200
          Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs wangyijing <wangyijing@huawei.com> - 2017-04-22 02:50 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs John Garry <john.garry@huawei.com> - 2017-04-21 10:40 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in  SAS HBA LLDDs Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-21 13:30 +0200
  Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host         in SAS HBA LLDDs Christoph Hellwig <hch@lst.de> - 2017-04-21 13:30 +0200

csiph-web