Re: [PATCH v5 7/7] perf report: Show branch type in callchain entry

From	"Jin, Yao" <yao.jin@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 7/7] perf report: Show branch type in callchain entry
Date	2017-04-20 02:40 +0200
Message-ID	<ty8iB-1OD-5@gated-at.bofh.it> (permalink)
References	<txSGR-FS-7@gated-at.bofh.it> <txSGV-FS-119@gated-at.bofh.it> <txYCB-4sd-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 4/19/2017 10:15 PM, Jiri Olsa wrote:
> On Wed, Apr 19, 2017 at 11:48:14PM +0800, Jin Yao wrote:
>
> SNIP
>
>> +static int branch_type_str(struct branch_type_stat *stat,
>> +			   char *bf, int bfsize)
>> +{
>> +	int i, j = 0, printed = 0;
>> +	u64 total = 0;
>> +
>> +	for (i = 0; i < PERF_BR_MAX; i++)
>> +		total += stat->counts[i];
>> +
>> +	if (total == 0)
>> +		return 0;
>> +
>> +	if (stat->jcc_fwd > 0)
>> +		printed += count_str_printf(j++, "JCC forward",
>> +				bf + printed, bfsize - printed);
>> +
>> +	if (stat->jcc_bwd > 0)
>> +		printed += count_str_printf(j++, "JCC backward",
>> +				bf + printed, bfsize - printed);
> please move that multiline conditional code inside {} brackets
>
> thanks,
> jirka

Thanks so much for all of your review comments. I will add the fix to v6.

Thanks
Jin Yao

Thread

[PATCH v5 0/7] perf report: Show branch type Jin Yao <yao.jin@linux.intel.com> - 2017-04-19 10:00 +0200
  [PATCH v5 5/7] perf util: Create branch.c/.h for common branch functions Jin Yao <yao.jin@linux.intel.com> - 2017-04-19 10:00 +0200
  [PATCH v5 7/7] perf report: Show branch type in callchain entry Jin Yao <yao.jin@linux.intel.com> - 2017-04-19 10:00 +0200
    Re: [PATCH v5 7/7] perf report: Show branch type in callchain entry Jiri Olsa <jolsa@redhat.com> - 2017-04-19 16:20 +0200
    Re: [PATCH v5 7/7] perf report: Show branch type in callchain entry Jiri Olsa <jolsa@redhat.com> - 2017-04-19 16:20 +0200
      Re: [PATCH v5 7/7] perf report: Show branch type in callchain entry "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-20 02:40 +0200
  [PATCH v5 3/7] perf record: Create a new option save_type in --branch-filter Jin Yao <yao.jin@linux.intel.com> - 2017-04-19 10:00 +0200
  [PATCH v5 6/7] perf report: Show branch type statistics for stdio mode Jin Yao <yao.jin@linux.intel.com> - 2017-04-19 10:00 +0200
    Re: [PATCH v5 6/7] perf report: Show branch type statistics for  stdio mode Jiri Olsa <jolsa@redhat.com> - 2017-04-19 16:20 +0200
    Re: [PATCH v5 6/7] perf report: Show branch type statistics for  stdio mode Jiri Olsa <jolsa@redhat.com> - 2017-04-19 16:20 +0200
  [PATCH v5 2/7] perf/x86/intel: Record branch type Jin Yao <yao.jin@linux.intel.com> - 2017-04-19 10:00 +0200

csiph-web