Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626800

Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()

Show all headers | View raw

On 04/19/2017 07:29 AM, Alexander Kochetkov wrote:
> The patch replace phy_start_aneg() with phy_start(). phy_start() call
> phy_start_aneg() as a part of startup sequence and allow recover from
> error (PHY_HALTED) state.
> 
> Also added call phy_stop() to arc_emac_remove() to stop PHY state machine
> when MAC is down.

This looks fine. If you wanted to go further, you could move the
phy_connect(), phy_disconnect() calls down to the arc_emac_open()
respectively arc_emac_stop() as this would also allow the PHY device to
be fully suspended when the interface is unused.

> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
>  drivers/net/ethernet/arc/emac_main.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
> index abc9f2a..188676d 100644
> --- a/drivers/net/ethernet/arc/emac_main.c
> +++ b/drivers/net/ethernet/arc/emac_main.c
> @@ -434,7 +434,7 @@ static int arc_emac_open(struct net_device *ndev)
>  	/* Enable EMAC */
>  	arc_reg_or(priv, R_CTRL, EN_MASK);
>  
> -	phy_start_aneg(ndev->phydev);
> +	phy_start(ndev->phydev);
>  
>  	netif_start_queue(ndev);
>  
> @@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
>  	napi_disable(&priv->napi);
>  	netif_stop_queue(ndev);
>  
> +	phy_stop(ndev->phydev);
> +
>  	/* Disable interrupts */
>  	arc_reg_clr(priv, R_ENABLE, RXINT_MASK | TXINT_MASK | ERR_MASK);
>  
> 


-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 16:40 +0200
  Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-19 20:30 +0200
  Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 23:10 +0200
    Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 23:20 +0200

csiph-web