[PATCH] net: arc_emac: switch to phy_start()/phy_stop()

From	Alexander Kochetkov <al.kochet@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: arc_emac: switch to phy_start()/phy_stop()
Date	2017-04-19 16:40 +0200
Message-ID	<txYVY-4yJ-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The patch replace phy_start_aneg() with phy_start(). phy_start() call
phy_start_aneg() as a part of startup sequence and allow recover from
error (PHY_HALTED) state.

Also added call phy_stop() to arc_emac_remove() to stop PHY state machine
when MAC is down.

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
 drivers/net/ethernet/arc/emac_main.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
index abc9f2a..188676d 100644
--- a/drivers/net/ethernet/arc/emac_main.c
+++ b/drivers/net/ethernet/arc/emac_main.c
@@ -434,7 +434,7 @@ static int arc_emac_open(struct net_device *ndev)
 	/* Enable EMAC */
 	arc_reg_or(priv, R_CTRL, EN_MASK);
 
-	phy_start_aneg(ndev->phydev);
+	phy_start(ndev->phydev);
 
 	netif_start_queue(ndev);
 
@@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
 	napi_disable(&priv->napi);
 	netif_stop_queue(ndev);
 
+	phy_stop(ndev->phydev);
+
 	/* Disable interrupts */
 	arc_reg_clr(priv, R_ENABLE, RXINT_MASK | TXINT_MASK | ERR_MASK);
 
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 16:40 +0200
  Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-19 20:30 +0200
  Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 23:10 +0200
    Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 23:20 +0200

csiph-web