Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1625017
| From | Matt Brown <matt@nmatt.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config |
| Date | 2017-04-18 06:40 +0200 |
| Message-ID | <txt5M-1FB-9@gated-at.bofh.it> (permalink) |
| References | <tx81j-5DY-7@gated-at.bofh.it> <tx81k-5DY-31@gated-at.bofh.it> <tx8NI-5UK-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/17/2017 02:50 AM, Greg KH wrote: > On Mon, Apr 17, 2017 at 02:07:03AM -0400, Matt Brown wrote: >> adding the kernel config SECURITY_TIOCSTI_RESTRICT in order to allow >> the user to restrict unprivileged command injection using TIOCSTI >> tty ioctls > > "unpriviledged command injection"? That sounds a bit "odd", don't you > think? > >> >> Signed-off-by: Matt Brown <matt@nmatt.com> >> --- >> security/Kconfig | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/security/Kconfig b/security/Kconfig >> index 3ff1bf9..d757bcb 100644 >> --- a/security/Kconfig >> +++ b/security/Kconfig >> @@ -18,6 +18,18 @@ config SECURITY_DMESG_RESTRICT >> >> If you are unsure how to answer this question, answer N. >> >> +config SECURITY_TIOCSTI_RESTRICT >> + bool "Restrict unprivileged use of tiocsti command injection" >> + default n >> + help >> + This enforces restrictions on unprivileged users injecting commands >> + into other processes in the same tty session using the TIOCSTI ioctl > > Tabs and spaces? > Sorry about that. Used the wrong vimrc for part of the Kconfig. Will fix in updated patch. > Since tty sessions are usually separated by different users, how would > they have the same one and yet need something like this? > > Also, why not put this in the tty config section? > > And finally, this patch on its own doesn't do anything :( > I will take your input, update my code, and resubmit as a single patch. > thanks, > > greg k-h >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config Matt Brown <matt@nmatt.com> - 2017-04-17 08:10 +0200
Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config Greg KH <gregkh@linuxfoundation.org> - 2017-04-17 09:00 +0200
Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config Matt Brown <matt@nmatt.com> - 2017-04-18 06:40 +0200
Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-04-18 16:30 +0200
Re: [kernel-hardening] Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config Kees Cook <keescook@chromium.org> - 2017-04-18 17:50 +0200
csiph-web