Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624969

RE: [RESEND PATCH] tools/power/x86/intel_pstate_tracer: Adjust directory permissions

Show all headers | View raw

On 2107.04.16 15:57 Rafael J. Wysocki wrote:
> On Sun, Apr 16, 2017 at 5:17 PM, Doug Smythies <doug.smythies@gmail.com> wrote:
>> Depending on what is being done, the intel_pstate_tracer.py script
>> needs to be run as root, or can be run as a regular user.
>> If run the first time as root the results directory will be
>> incorrect for any subsequent run as a regular user.
>
> Which is OK.
>
> For security reasons, non-root should not be able to modify root-owned
> directories.

Hi Rafael,

I do not see a security issue here.

The objective was to merge what used to be
two steps (with the old, never released, post processing tools)
into one step. The only reason "root" was ever needed was for
the actual trace step. In the past everything else could be
done as a regular user. Even when the two step method is used
and we are processing a previously acquired (as "root"), it is
preferred to do so as a regular user.

Anyway, in a minute I will send a version 2 of the patch, where
the user and group IDs are changed to regular user, rather than
changing permissions.

... Doug

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] tools/power/x86/intel_pstate_tracer: Adjust directory permissions Doug Smythies <doug.smythies@gmail.com> - 2017-04-16 17:20 +0200
  Re: [RESEND PATCH] tools/power/x86/intel_pstate_tracer: Adjust  directory permissions "Rafael J. Wysocki" <rafael@kernel.org> - 2017-04-17 01:00 +0200
  RE: [RESEND PATCH] tools/power/x86/intel_pstate_tracer: Adjust directory permissions "Doug Smythies" <dsmythies@telus.net> - 2017-04-18 02:20 +0200

csiph-web