Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling
Date	2017-04-17 17:10 +0200
Message-ID	<txgrU-2bp-29@gated-at.bofh.it> (permalink)
References	<tvrB8-5Bn-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Wed, 12 Apr 2017 16:21:38 +0200

> Commit 1045ba77a ("net sched actions: Add support for user cookies")
> added code to net/sched/act_api.c's tcf_action_init_1 using the `tb`
> nlattr array unconditionally, while it was otherwise used as well as
> initialized only when `name == NULL`:
...
> I'm not sure why the TC_ACT_COOKIE code was added to tcf_action_init_1
> where it is now. It makes me think that it's supposed to be available
> universally, but the `name == NULL` check for how nla is used or passed
> to ->init() shows that the there are various different TC_ACT_* enums in
> use at this point, hence the 'RFC' part of the patches, I'm not that
> familiar with the code yet.

Jamal please review this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-12 16:40 +0200
  [PATCH linux 2/2] net sched actions: fix refcount decrement on error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-12 16:40 +0200
    Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-13 06:30 +0200
      Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on  error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-13 10:10 +0200
        Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-13 20:10 +0200
          Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on  error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-14 11:10 +0200
            Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-15 20:30 +0200
              Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on  error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-15 20:50 +0200
                Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-17 20:20 +0200
    Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Roman Mashak <mrv@mojatatu.com> - 2017-04-13 15:50 +0200
  Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized  data and error handling Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-13 03:30 +0200
  Re: [RFC PATCH linux 0/2] net sched actions: access to  uninitialized data and error handling David Miller <davem@davemloft.net> - 2017-04-17 17:10 +0200

csiph-web