Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624124

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

Show all headers | View raw

On Fri, Apr 14, 2017 at 2:08 AM, Wolfgang Bumiller
<w.bumiller@proxmox.com> wrote:
> Before I do that - trying to wrap my head around the interdependencies
> here better to be thorough - I noticed that tcf_hash_release() can
> return ACT_P_DELETED. The ACT_P_CREATED case means tcf_hash_create()
> was used, in the other case the tc_action's ref & bind count is bumped
> by tcf_hash_check() and then also decremented by tcf_hash_release() if
> it existed, iow. kept at 1, but not always: It does always happen in
> act_police.c but in other files such as act_bpf.c or act_connmark.c if
> eg. bind is set they return without decrementing, so both ref&bind count
> are bumped when they return - the refcount logic isn't easy to follow
> for a newcomer. Now there are two uses of __tcf_hash_release() in
> act_api.c which check for a return value of ACT_P_DELETED, in which case
> they call module_put().


That's the nasty part... IIRC, Jamal has fixed two bugs on action refcnt'ing.
We really need to clean up the code.

> So I'm not sure exactly how the module and tc_action counts are related
> (and I usually like to understand my own patches ;-) ).


Each action holds a refcnt to its module, each filter holds a refcnt to
its bound or referenced (unbound) action.


> Maybe I'm missing something obvious but I'm currently a bit confused as
> to whether the tcf_hash_release() call there is okay, or should have its
> return value checked or should depend on ->init()'s ACT_P_CREATED value
> as well?
>

I think it's the same? If we have ACT_P_CREATED here, tcf_hash_release()
will return ACT_P_DELETED for sure because the newly created action has
refcnt==1?

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-12 16:40 +0200
  [PATCH linux 2/2] net sched actions: fix refcount decrement on error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-12 16:40 +0200
    Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-13 06:30 +0200
      Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on  error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-13 10:10 +0200
        Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-13 20:10 +0200
          Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on  error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-14 11:10 +0200
            Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-15 20:30 +0200
              Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on  error Wolfgang Bumiller <w.bumiller@proxmox.com> - 2017-04-15 20:50 +0200
                Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-17 20:20 +0200
    Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error Roman Mashak <mrv@mojatatu.com> - 2017-04-13 15:50 +0200
  Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized  data and error handling Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-13 03:30 +0200
  Re: [RFC PATCH linux 0/2] net sched actions: access to  uninitialized data and error handling David Miller <davem@davemloft.net> - 2017-04-17 17:10 +0200

csiph-web