Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626403

Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 2017-04-19 at 08:23 -0700, Andrey Smirnov wrote:
> No functional change intended.

FWIW I *deliberately* used the proper C datatypes throughout all of the
MTD code instead of the silly kernel-speshul datatypes. To the extent
of *fixing* submissions to be written in C when they were using the
silly kernel types instead.

There is a reason for the __u32 type in userspace APIs. There is
basically no reason for 'u32' et al, just to save a trivial few
characters in the type name. We might as well be using the proper
language types.

I appreciate that not everyone agrees with that, but at least it used
to be consistent throughout the code I was maintaining. I'll defer to
the currently active maintainers though...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 17:30 +0200
  [PATCH v3 4/6] mtd: dataflash: Get rid of loop counter in jedec_probe() Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 17:30 +0200
    Re: [PATCH v3 4/6] mtd: dataflash: Get rid of loop counter in  jedec_probe() Marek Vasut <marek.vasut@gmail.com> - 2017-04-19 17:50 +0200
  [PATCH v3 2/6] mtd: dataflash: Improve coding style in jedec_probe() Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 17:30 +0200
  Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their  kernel counterparts David Woodhouse <dwmw2@infradead.org> - 2017-04-19 17:40 +0200
    Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their  kernel counterparts Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 18:10 +0200

csiph-web