Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626372

[PATCH v3 4/6] mtd: dataflash: Get rid of loop counter in jedec_probe()

Show all headers | View raw

"For" loop in jedec_probe can be simplified to not need counter
'i'. Convert the code and get rid of the variable.

Cc: cphealy@gmail.com
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---

Not present in v2, v1.

 drivers/mtd/devices/mtd_dataflash.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index ccd1e02..2d3e403 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -736,7 +736,7 @@ static struct flash_info dataflash_data[] = {
 
 static struct flash_info *jedec_probe(struct spi_device *spi)
 {
-	int ret, i;
+	int ret;
 	u8 code = OP_READ_ID;
 	u8 id[3];
 	u32 jedec;
@@ -767,9 +767,9 @@ static struct flash_info *jedec_probe(struct spi_device *spi)
 	jedec = jedec << 8;
 	jedec |= id[2];
 
-	for (i = 0, info = dataflash_data;
-			i < ARRAY_SIZE(dataflash_data);
-			i++, info++) {
+	for (info = dataflash_data;
+	     info < dataflash_data + ARRAY_SIZE(dataflash_data);
+	     info++) {
 		if (info->jedec_id == jedec) {
 			dev_dbg(&spi->dev, "OTP, sector protect%s\n",
 				(info->flags & SUP_POW2PS) ?
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] mtd: dataflash: Replace C99 types with their kernel counterparts Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 17:30 +0200
  [PATCH v3 4/6] mtd: dataflash: Get rid of loop counter in jedec_probe() Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 17:30 +0200
    Re: [PATCH v3 4/6] mtd: dataflash: Get rid of loop counter in  jedec_probe() Marek Vasut <marek.vasut@gmail.com> - 2017-04-19 17:50 +0200
  [PATCH v3 2/6] mtd: dataflash: Improve coding style in jedec_probe() Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 17:30 +0200
  Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their  kernel counterparts David Woodhouse <dwmw2@infradead.org> - 2017-04-19 17:40 +0200
    Re: [PATCH v3 1/6] mtd: dataflash: Replace C99 types with their  kernel counterparts Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-19 18:10 +0200

csiph-web