Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625326

Re: [PATCH] mm: Add additional consistency check

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Christoph Lameter <cl@linux.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: Add additional consistency check
Date Tue, 18 Apr 2017 15:40:02 +0200
Message-ID <txBwm-6Is-11@gated-at.bofh.it> (permalink)
References <tv4XU-8aE-23@gated-at.bofh.it> <tv6Gm-QX-17@gated-at.bofh.it> <tv79n-11Q-5@gated-at.bofh.it> <tv8oO-22T-23@gated-at.bofh.it> <tv8RQ-2eB-17@gated-at.bofh.it> <tv91w-2ie-19@gated-at.bofh.it> <tv9bc-2lS-5@gated-at.bofh.it> <tv9bc-2lS-11@gated-at.bofh.it> <tv9NU-2Ow-13@gated-at.bofh.it> <txgLf-2iD-7@gated-at.bofh.it> <txv7z-2Ti-3@gated-at.bofh.it>
X-X-Sender cl@east.gentwo.org
Content-Type text/plain; charset=US-ASCII
X-Cmae-Envelope MS4wfHSA6chagp04b2ezTL5WR2vHFZqshgy4+N5okM38RygABQBNPczAwj+AW+jVyLYpGlkb+/7f2liBOCm5i4E94LOZo3PtTaCkeGLylY3D05ExGWLf93ju UCGzfbPTcZyYaqDhKeknxT678MMWAG+Ym/BDK+ld/WEkKfHizBx/nfRxeOAVp3VNlWULZ3ifmqV7IjB6yY5BteKl7vyr/DAbceTeWFjfjNa2IroMnPuuW8uW DQQXcUHacBTcT1Eo+XFG3kxRuxHLLZXjSufHMOiTck1u5T1vN2qBy/5rmK4b/iD37AKIjgAn+co9km9jynD+H5yS3wQWdZo5fU5F0wtI+YzP8GpeRmzKLGOs A5CLLyC4j2PJZQVu4Ff6iOqrbZCJVQsbZD1ElqS+G5iCz19URAU=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 15
Organization linux.* mail to news gateway
X-Original-Cc Kees Cook <keescook@chromium.org>, Andrew Morton <akpm@linux-foundation.org>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date Tue, 18 Apr 2017 08:37:13 -0500 (CDT)
X-Original-Message-ID <alpine.DEB.2.20.1704180834570.13829@east.gentwo.org>
X-Original-References <20170411141956.GP6729@dhcp22.suse.cz> <alpine.DEB.2.20.1704111110130.24725@east.gentwo.org> <20170411164134.GA21171@dhcp22.suse.cz> <alpine.DEB.2.20.1704111254390.25069@east.gentwo.org> <20170411183035.GD21171@dhcp22.suse.cz> <alpine.DEB.2.20.1704111335540.6544@east.gentwo.org> <20170411185555.GE21171@dhcp22.suse.cz> <alpine.DEB.2.20.1704111356460.6911@east.gentwo.org> <20170411193948.GA29154@dhcp22.suse.cz> <alpine.DEB.2.20.1704171021450.28407@east.gentwo.org> <20170418064124.GA22360@dhcp22.suse.cz>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1625326

Show key headers only | View raw

On Tue, 18 Apr 2017, Michal Hocko wrote:

> Are you even reading those emails? First of all we are talking about
> slab here. Secondly I've already pointed out that the BUG_ON(!PageSlab)
> in kmem_freepages is already too late because we do operate on a
> potential garbage from invalid page...

Before I forget:

1. The patch affects both slab and slub since it patches mm/slab.h and is
called by both allocators.

2. The check in the patch we are discussing here when calling
kmem_cache_free() will be executing before kmem_freepages() is called
in slab.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 07:00 +0200
  Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 15:50 +0200
    Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 16:20 +0200
      Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 16:30 +0200
        Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 18:10 +0200
        Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 18:20 +0200
          Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 18:30 +0200
          Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 18:30 +0200
            Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 18:40 +0200
        Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 18:20 +0200
          Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 18:50 +0200
            Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 20:10 +0200
              Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 20:40 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 20:50 +0200
                Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 21:00 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 21:00 +0200
                Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 21:40 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-17 17:30 +0200
                Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-18 08:50 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-18 15:40 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-18 15:40 +0200

csiph-web