Re: [PATCH] mm: Add additional consistency check

From	Christoph Lameter <cl@linux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: Add additional consistency check
Date	2017-04-18 15:40 +0200
Message-ID	<txBwm-6Is-13@gated-at.bofh.it> (permalink)
References	(6 earlier) <tv9bc-2lS-5@gated-at.bofh.it> <tv9bc-2lS-11@gated-at.bofh.it> <tv9NU-2Ow-13@gated-at.bofh.it> <txgLf-2iD-7@gated-at.bofh.it> <txv7z-2Ti-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 18 Apr 2017, Michal Hocko wrote:

> > The patch does not do that. See my review. Invalid points to kfree are
> > already caught with a bug on. See kfree in mm/slub.c
>
> Are you even reading those emails? First of all we are talking about
> slab here. Secondly I've already pointed out that the BUG_ON(!PageSlab)
> in kmem_freepages is already too late because we do operate on a
> potential garbage from invalid page...

Again this is confusing because you are discussing something that was not
covered by the patch submitted. Please start another discussion thread
on kfree() separately from the discussion of the patch here.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 07:00 +0200
  Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 15:50 +0200
    Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 16:20 +0200
      Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 16:30 +0200
        Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 18:10 +0200
        Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 18:20 +0200
          Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 18:30 +0200
          Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 18:30 +0200
            Re: [PATCH] mm: Add additional consistency check Kees Cook <keescook@chromium.org> - 2017-04-11 18:40 +0200
        Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 18:20 +0200
          Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 18:50 +0200
            Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 20:10 +0200
              Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 20:40 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 20:50 +0200
                Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 21:00 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-11 21:00 +0200
                Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-11 21:40 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-17 17:30 +0200
                Re: [PATCH] mm: Add additional consistency check Michal Hocko <mhocko@kernel.org> - 2017-04-18 08:50 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-18 15:40 +0200
                Re: [PATCH] mm: Add additional consistency check Christoph Lameter <cl@linux.com> - 2017-04-18 15:40 +0200

csiph-web