Re: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe()
Date	2017-04-15 19:30 +0200
Message-ID	<twzGi-YI-7@gated-at.bofh.it> (permalink)
References	<twgDD-69I-3@gated-at.bofh.it> <twgDE-69I-5@gated-at.bofh.it> <twtrc-5tU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kcalloc".
>>
>> This issue was detected by using the Coccinelle software.
> 
> Unfortunately you write mostly cryptic commit messages.

Thanks for your feedback.


> This does not answer for the main question - why this change is needed.

My update suggestion affects an aspect for the coding style.


> Code looks okay,

There can be different opinions about related implementation details.


> but you should explain in simple words why this is needed.

Do you find the following wording from the script “checkpatch.pl”
better to understand?

WARNING: Prefer kcalloc over kzalloc with multiply


Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-14 23:10 +0200
  Re: [PATCH 1/2] regulator: s2mps11: Use kcalloc() in  s2mps11_pmic_probe() Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-15 12:50 +0200
    Re: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-15 19:30 +0200

csiph-web