[PATCH 1/2] regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe()
Date	2017-04-14 23:10 +0200
Message-ID	<twgDE-69I-5@gated-at.bofh.it> (permalink)
References	<twgDD-69I-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 14 Apr 2017 22:00:35 +0200

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/regulator/s2mps11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index 7726b874e539..b4e588cce03d 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -1162,7 +1162,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
 		}
 	}
 
-	rdata = kzalloc(sizeof(*rdata) * rdev_num, GFP_KERNEL);
+	rdata = kcalloc(rdev_num, sizeof(*rdata), GFP_KERNEL);
 	if (!rdata)
 		return -ENOMEM;
 
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-14 23:10 +0200
  Re: [PATCH 1/2] regulator: s2mps11: Use kcalloc() in  s2mps11_pmic_probe() Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-15 12:50 +0200
    Re: regulator: s2mps11: Use kcalloc() in s2mps11_pmic_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-15 19:30 +0200

csiph-web