NFC-FDP: Completion of error handling around fdp_nci_i2c_read_device_properties()

Path	csiph.com!weretis.net!feeder6.news.weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	NFC-FDP: Completion of error handling around fdp_nci_i2c_read_device_properties()
Date	Sat, 15 Apr 2017 10:00:01 +0200
Message-ID	<twqMF-3T3-3@gated-at.bofh.it> (permalink)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-GB
Content-Transfer-Encoding	8bit
X-Provags-ID	V03:K0:qhHSf/ict//PJvGINmjNk5q3JnJl5ZnP3s5uMxetok+WxKWIZ9z 9O5DihPHVaemIyiRuWCjPRTpADMrjMzgT0Oj4Gr0Vhn1Q06cRAsJblJVJEeFgFHdhDU7Jx1 rQVRBS7MLS5i4mt4jaX7m3OY/6zmEtzxgXS5fXmMhzoZkuM4J66MpX4w0uUAt+hS2onzSOj JvObKtRJmiz1Dfc69hGWw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:Kfdx1gXSi/c=:UtZIL9NHTAqDa1uFxUBJLn sBlWoq8UNe6mFFT6MtWTU93rIt/TKqteo6r4CNVo1kdvqNZgKTUy0KtkaZZg9WTzWbIIP2X5i amAjecsm9i7Ifng9TSz4TEtOf4SdfTCj5WRPlfJaWs3Q2+VepnUeHmTVewjZZIFt0nam1SVPZ lilz3wCs4x6PkX9jZm1e5ojFiOHqvLatYi4qgIp0j5e7btpjQn4yL1UjoYQC4HMu6yUmeGLMO jesRJJJOrtPPvm7GPW/jPJ2s+7ia2c9NQ0VdAG7RqWlE2CurPhGfaZEuVtgGrTc2qD5NBzzca 9Di6Acc1Fv4e/jR4SrNTwJd2ALCqsA4rovqfOH8+zvgtO8fV9o5p5v/DRKxewaZ1Gg551MFVt yp6OL+r6qwyegdKVYgVE7oh4F1BlBeTJUAUiayNFrI6tFJV9fDJ+uqwl6UJK7rTEcOBIpOe/A gY5VxU+eWKSNqrqR7kK6OwOu17BWM8hLuAfLV2DK2tCxNUL4vyVTub9YJaM2U2ebnt1Ow/f8R sifZlsWURou/v7eTgpodB/9JV70wz9YRyB4o1/9lEO1f9dDmYrfN0gFytoG5kdXJsjSRHJZs0 pk8FtkEa/CFSRzKnsddEPBGx+Z2K3GsRNlkHFU4HpXV0EaRmwPhkYIeZ9CcXzUEMOmxbxlB1c w+lV9QxWoA9+vvXU53DnbFVHqOWjN1nvdvPcLk+iK7cflVUpVJ/T106zkDypLyzNfCH0ZoxSQ xSIFyE0Uc+/Xk8QfJ+42JORH1XodS9kZaEilfH48EubPuLsEAgWgmqWLO+U2ZKF2VB8y9xiVe Q0ONEfK
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	11
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Sat, 15 Apr 2017 09:51:38 +0200
X-Original-Message-ID	<235c865e-b66f-9fb7-2f8e-93c62cacb988@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1624039

Show key headers only | View raw

Hello,

I have noticed that the function “fdp_nci_i2c_read_device_properties” does not
contain a null pointer check after a call of the function “devm_kmalloc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nfc/fdp/i2c.c?h=v4.10#n234

How do you think about to add a corresponding check and adjust the function
return type there?

Regards,
Markus

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

NFC-FDP: Completion of error handling around  fdp_nci_i2c_read_device_properties() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-15 10:00 +0200

csiph-web