NFC-FDP: Completion of error handling around fdp_nci_i2c_read_device_properties()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	NFC-FDP: Completion of error handling around fdp_nci_i2c_read_device_properties()
Date	2017-04-15 10:00 +0200
Message-ID	<twqMF-3T3-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

I have noticed that the function “fdp_nci_i2c_read_device_properties” does not
contain a null pointer check after a call of the function “devm_kmalloc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nfc/fdp/i2c.c?h=v4.10#n234

How do you think about to add a corresponding check and adjust the function
return type there?

Regards,
Markus

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

NFC-FDP: Completion of error handling around  fdp_nci_i2c_read_device_properties() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-15 10:00 +0200

csiph-web