Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623801

Re: [PATCH 2/4] genirq: return the irq name from free_irq

Show all headers | View raw

On Thu, 13 Apr 2017, Christoph Hellwig wrote:

> This allows callers to get back at them instead of having to store
> it in another variable.

Alternatively you tell the irq code to free it for you. Patch below.

Thanks,

	tglx

8<-----------------------

--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -60,7 +60,9 @@
  * IRQF_COND_SUSPEND - If the IRQ is shared with a NO_SUSPEND user, execute this
  *                interrupt handler after suspending interrupts. For system
  *                wakeup devices users need to implement wakeup detection in
- *                their interrupt handlers.
+ *                their interrupt handlers
+ * IRQF_FREE_NAME - Free the memory pointed to by the @name argument of
+ *		    request_irq() in free_irq()
  */
 #define IRQF_SHARED		0x00000080
 #define IRQF_PROBE_SHARED	0x00000100
@@ -74,6 +76,7 @@
 #define IRQF_NO_THREAD		0x00010000
 #define IRQF_EARLY_RESUME	0x00020000
 #define IRQF_COND_SUSPEND	0x00040000
+#define IRQF_FREE_NAME		0x00080000
 
 #define IRQF_TIMER		(__IRQF_TIMER | IRQF_NO_SUSPEND | IRQF_NO_THREAD)
 
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1542,6 +1542,8 @@ static struct irqaction *__free_irq(unsi
 	irq_chip_pm_put(&desc->irq_data);
 	module_put(desc->owner);
 	kfree(action->secondary);
+	if (action->flags & IRQF_FREE_NAME)
+		kfree(action->name);
 	return action;
 }
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

provide pci_request_irq / pci_free_irq helpers Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
  [PATCH 1/4] genirq: fix indentation in remove_irq Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
    Re: [PATCH 1/4] genirq: fix indentation in remove_irq Thomas Gleixner <tglx@linutronix.de> - 2017-04-14 19:30 +0200
    Re: [PATCH 1/4] genirq: fix indentation in remove_irq Sagi Grimberg <sagi@grimberg.me> - 2017-04-20 15:30 +0200
  [PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq helpers Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
    Re: [PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq helpers Bjorn Helgaas <helgaas@kernel.org> - 2017-04-14 16:50 +0200
      Re: [PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq         helpers Christoph Hellwig <hch@lst.de> - 2017-04-14 18:00 +0200
  [PATCH 2/4] genirq: return the irq name from free_irq Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
    Re: [PATCH 2/4] genirq: return the irq name from free_irq Thomas Gleixner <tglx@linutronix.de> - 2017-04-14 19:30 +0200
      Re: [PATCH 2/4] genirq: return the irq name from free_irq Christoph Hellwig <hch@lst.de> - 2017-04-14 19:40 +0200
        Re: [PATCH 2/4] genirq: return the irq name from free_irq Thomas Gleixner <tglx@linutronix.de> - 2017-04-14 20:00 +0200
  Re: provide pci_request_irq / pci_free_irq helpers Bjorn Helgaas <helgaas@kernel.org> - 2017-04-18 20:50 +0200

csiph-web