Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1623819
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] genirq: return the irq name from free_irq |
| Date | 2017-04-14 20:00 +0200 |
| Message-ID | <twdFM-43B-15@gated-at.bofh.it> (permalink) |
| References | <tvH3c-7S2-5@gated-at.bofh.it> <tvH3c-7S2-25@gated-at.bofh.it> <twdcJ-3T6-3@gated-at.bofh.it> <twdmq-3Wz-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 14 Apr 2017, Christoph Hellwig wrote:
> On Fri, Apr 14, 2017 at 07:28:42PM +0200, Thomas Gleixner wrote:
> > On Thu, 13 Apr 2017, Christoph Hellwig wrote:
> >
> > > This allows callers to get back at them instead of having to store
> > > it in another variable.
> >
> > Alternatively you tell the irq code to free it for you. Patch below.
>
> Yes, this should work to. But I think having the same layer free
> something they allocated again is a tad cleaner in terms of layering.
Fair enough. Was just a thought.
Bjorn, please route it through PCI alltogether.
For the whole series:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
provide pci_request_irq / pci_free_irq helpers Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
[PATCH 1/4] genirq: fix indentation in remove_irq Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
Re: [PATCH 1/4] genirq: fix indentation in remove_irq Thomas Gleixner <tglx@linutronix.de> - 2017-04-14 19:30 +0200
Re: [PATCH 1/4] genirq: fix indentation in remove_irq Sagi Grimberg <sagi@grimberg.me> - 2017-04-20 15:30 +0200
[PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq helpers Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
Re: [PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq helpers Bjorn Helgaas <helgaas@kernel.org> - 2017-04-14 16:50 +0200
Re: [PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq helpers Christoph Hellwig <hch@lst.de> - 2017-04-14 18:00 +0200
[PATCH 2/4] genirq: return the irq name from free_irq Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200
Re: [PATCH 2/4] genirq: return the irq name from free_irq Thomas Gleixner <tglx@linutronix.de> - 2017-04-14 19:30 +0200
Re: [PATCH 2/4] genirq: return the irq name from free_irq Christoph Hellwig <hch@lst.de> - 2017-04-14 19:40 +0200
Re: [PATCH 2/4] genirq: return the irq name from free_irq Thomas Gleixner <tglx@linutronix.de> - 2017-04-14 20:00 +0200
Re: provide pci_request_irq / pci_free_irq helpers Bjorn Helgaas <helgaas@kernel.org> - 2017-04-18 20:50 +0200
csiph-web