Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT violation

From	David Hildenbrand <david@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT violation
Date	2017-04-12 22:10 +0200
Message-ID	<tvwKu-Gu-7@gated-at.bofh.it> (permalink)
References	<tqF21-4or-3@gated-at.bofh.it> <tqF21-4or-13@gated-at.bofh.it>
Organization	Red Hat GmbH

Show all headers | View raw

On 30.03.2017 11:55, Paolo Bonzini wrote:
> handle_ept_violation is checking for "guest-linear-address invalid" +
> "not a paging-structure walk".  However, _all_ EPT violations without
> a valid guest linear address are paging structure walks, because those
> EPT violations happen when loading the guest PDPTEs.
> 
> Therefore, the check can never be true, and even if it were, KVM doesn't
> care about the guest linear address; it only uses the guest *physical*
> address VMCS field.  So, remove the check altogether.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT  violation David Hildenbrand <david@redhat.com> - 2017-04-12 22:10 +0200

csiph-web