Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1622495

[PATCH v2 3/5] drm/msm: Reuse dma_fence_release.

Show all headers | View raw

If we follow the typical pattern of the base class being the first
member, we can use the default dma_fence_free function.

Signed-off-by: Eric Anholt <eric@anholt.net>
Cc: Rob Clark <robdclark@gmail.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
---
 drivers/gpu/drm/msm/msm_fence.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_fence.c b/drivers/gpu/drm/msm/msm_fence.c
index 3f299c537b77..a2f89bac9c16 100644
--- a/drivers/gpu/drm/msm/msm_fence.c
+++ b/drivers/gpu/drm/msm/msm_fence.c
@@ -99,8 +99,8 @@ void msm_update_fence(struct msm_fence_context *fctx, uint32_t fence)
 }
 
 struct msm_fence {
-	struct msm_fence_context *fctx;
 	struct dma_fence base;
+	struct msm_fence_context *fctx;
 };
 
 static inline struct msm_fence *to_msm_fence(struct dma_fence *fence)
@@ -130,19 +130,13 @@ static bool msm_fence_signaled(struct dma_fence *fence)
 	return fence_completed(f->fctx, f->base.seqno);
 }
 
-static void msm_fence_release(struct dma_fence *fence)
-{
-	struct msm_fence *f = to_msm_fence(fence);
-	kfree_rcu(f, base.rcu);
-}
-
 static const struct dma_fence_ops msm_fence_ops = {
 	.get_driver_name = msm_fence_get_driver_name,
 	.get_timeline_name = msm_fence_get_timeline_name,
 	.enable_signaling = msm_fence_enable_signaling,
 	.signaled = msm_fence_signaled,
 	.wait = dma_fence_default_wait,
-	.release = msm_fence_release,
+	.release = dma_fence_free,
 };
 
 struct dma_fence *
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] vc4 V3D fencing and msm/etnaviv cleanups Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
  [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
    Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. Daniel Vetter <daniel@ffwll.ch> - 2017-04-13 09:10 +0200
  [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
    Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Daniel Vetter <daniel@ffwll.ch> - 2017-04-13 09:20 +0200
      Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Eric Anholt <eric@anholt.net> - 2017-04-13 19:20 +0200
      Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Eric Anholt <eric@anholt.net> - 2017-04-13 20:10 +0200
  [PATCH v2 2/5] drm/etnaviv: Expose our reservation object when exporting a dmabuf. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
  [PATCH v2 1/5] drm/msm: Expose our reservation object when exporting a dmabuf. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
  [PATCH v2 3/5] drm/msm: Reuse dma_fence_release. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200

csiph-web