Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1623239
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. |
| Date | 2017-04-13 20:10 +0200 |
| Message-ID | <tvRlU-6FZ-21@gated-at.bofh.it> (permalink) |
| References | <tvvY5-8tR-5@gated-at.bofh.it> <tvvY6-8tR-17@gated-at.bofh.it> <tvHcS-7Xz-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Daniel Vetter <daniel@ffwll.ch> writes: > On Wed, Apr 12, 2017 at 12:12:02PM -0700, Eric Anholt wrote: >> This is needed for proper synchronization with display on another DRM >> device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the >> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2 >> desktop tests on pl111+vc4. >> >> This doesn't yet introduce waits on other device's fences before vc4's >> rendering/display, because I don't have testcases for them. >> >> v2: Reuse dma_fence_free(), retitle commit message to clarify that >> it's not a full dma-buf fencing implementation yet. >> >> Signed-off-by: Eric Anholt <eric@anholt.net> > > Double-checked a few things in your ww_mutex scheme, seems are correct. > And testing with CONFIG_DEBUG_WW_MUTEX_SLOWPATH should catch any kind of > fumbles in your error paths. I didnt do a full review, so just > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> The two other most likely reviewers (ickle and padovan) have at least glanced at it, so I've pushed it now.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/5] vc4 V3D fencing and msm/etnaviv cleanups Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
[PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. Daniel Vetter <daniel@ffwll.ch> - 2017-04-13 09:10 +0200
[PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Daniel Vetter <daniel@ffwll.ch> - 2017-04-13 09:20 +0200
Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Eric Anholt <eric@anholt.net> - 2017-04-13 19:20 +0200
Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. Eric Anholt <eric@anholt.net> - 2017-04-13 20:10 +0200
[PATCH v2 2/5] drm/etnaviv: Expose our reservation object when exporting a dmabuf. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
[PATCH v2 1/5] drm/msm: Expose our reservation object when exporting a dmabuf. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
[PATCH v2 3/5] drm/msm: Reuse dma_fence_release. Eric Anholt <eric@anholt.net> - 2017-04-12 21:20 +0200
csiph-web