[PATCH] Input: ar1021 - do not force raising edge IRQ trigger

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Input: ar1021 - do not force raising edge IRQ trigger
Date	Fri, 14 Apr 2017 01:50:01 +0200
Message-ID	<tvWEV-1Js-21@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=1nK7Dys70hEJVw5BR1ZFhytor8Ae1JIiie3fi+cS0fw=; b=o/G2f8o+sRBHYiHKcjQ8PdHPtWmKLHR6RslYwKt7WzL0RMPaNuH5GZ0+JJWMmz6MSa U85tb+xQTPjv0LjPLfJtYURbXOLasy1UXq2fPVZ6VhkY6LQuwtCfILkFa6b2gsn7i/wt r/iumEvnI9K7/HerZb106G9z8yuvaUEdxwboXAw0gQ78JbFriiyH650anGMiZrpAJ9fo JWhSns+c8sW+XiGWmjElXrDQ7l1qj0YANxRFu+x8tt0s7poVWJRafOhdQjM50BlDkGrm jHJItWyjjnpJ9jWN6as8l9DFrIW1NfdE4nNKvT5iDUpQgf/pUv6UaOAV4mgUX1rCLXD2 QSxw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=1nK7Dys70hEJVw5BR1ZFhytor8Ae1JIiie3fi+cS0fw=; b=Mqtp/G/Ux/vZMkm8hdMJAut8dHI2rtCgQSJsg9Y4n+NWX27PTzHOLg57KU5JRVRkvr gsr8wee96085hbJolg7TpAeFVFFU18qbigflM40YQe5+xsPqpZGkJ6q0cDp2DBWvowlf JDKekx3QW8Lb+xAEicHHHqprDyYJeJLpann5DMYxTnSjEuJo/X1Wx13WSq996paELl4r HhUWqosgBDFcvyCpFSE7M1HchJnwRkGKiKsDn7aQFX/0fntCOYQpriU/Qaca4wBw0Q/5 TKglLikcrZzpVZk/emRhimklXZNLOqMuQMmL33wq6jfSTIwDfKLO/k0/AAW8exxlAc0S RX+A==
X-Gm-Message-State	AN3rC/4CLq6ii9Z7Tg54DlTjP2PD4iPp+R4g7wNrMVoGhJDaDIXyN5L7 4z0vmBP32jKC9Q==
X-Received	by 10.98.166.197 with SMTP id r66mr4405462pfl.5.1492127366639; Thu, 13 Apr 2017 16:49:26 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Martin Kepplinger <martin.kepplinger@ginzinger.com>, Guenter Roeck <linux@roeck-us.net>, Wolfram Sang <wsa@the-dreams.de>, Jean Delvare <jdelvare@suse.com>, Christian Gmeiner <christian.gmeiner@gmail.com>, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 13 Apr 2017 16:49:23 -0700
X-Original-Message-ID	<20170413234923.GA38321@dtor-ws>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1623434

Show key headers only | View raw

We should not be forcing edge triggered interrupt, but rather let platform
decide the kind of trigger it needs to use. Also, the driver is not quite
safe with regard to edge-triggered interrupts as it does not try to kick
the controller after requesting/enabling IRQ.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/ar1021_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index 6797e123925a..6c3c79b7ff51 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
 
 	error = devm_request_threaded_irq(&client->dev, client->irq,
 					  NULL, ar1021_i2c_irq,
-					  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					  IRQF_ONESHOT,
 					  "ar1021_i2c", ar1021);
 	if (error) {
 		dev_err(&client->dev,
-- 
2.12.2.762.g0e3151a226-goog


-- 
Dmitry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Input: ar1021 - do not force raising edge IRQ trigger Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-04-14 01:50 +0200
  Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Martin Kepplinger <martin.kepplinger@ginzinger.com> - 2017-04-14 08:00 +0200
  Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Christian Gmeiner <christian.gmeiner@gmail.com> - 2017-04-14 09:40 +0200
  Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Jean Delvare <jdelvare@suse.de> - 2017-04-15 08:50 +0200

csiph-web