Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624034

Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger

Show all headers | View raw

On Thu, 13 Apr 2017 16:49:23 -0700, Dmitry Torokhov wrote:
> We should not be forcing edge triggered interrupt, but rather let platform
> decide the kind of trigger it needs to use. Also, the driver is not quite
> safe with regard to edge-triggered interrupts as it does not try to kick
> the controller after requesting/enabling IRQ.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/touchscreen/ar1021_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index 6797e123925a..6c3c79b7ff51 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
>  
>  	error = devm_request_threaded_irq(&client->dev, client->irq,
>  					  NULL, ar1021_i2c_irq,
> -					  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +					  IRQF_ONESHOT,
>  					  "ar1021_i2c", ar1021);
>  	if (error) {
>  		dev_err(&client->dev,

Acked-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: ar1021 - do not force raising edge IRQ trigger Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-04-14 01:50 +0200
  Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Martin Kepplinger <martin.kepplinger@ginzinger.com> - 2017-04-14 08:00 +0200
  Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Christian Gmeiner <christian.gmeiner@gmail.com> - 2017-04-14 09:40 +0200
  Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Jean Delvare <jdelvare@suse.de> - 2017-04-15 08:50 +0200

csiph-web