Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1622853

Re: [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts

Show all headers | View raw

On Tue, 11 Apr 2017 13:31:16 +0300 Adrian Hunter wrote:

> On 11/04/17 13:20, Jisheng Zhang wrote:
> > We found one issue on BG4CT platforms with GPIO for sdcar card detect
> > interrupt: remove sdcard when there's read write access to the sdcard,
> > sometimes the card remove event can't be handled for a long time, so
> > the  system still think the sdcard is still plugged in. It turns out
> > that the sdhci_card_event() is missing in common slot gpio's card
> > detect isr.  
> 
> ->card_event() is called by mmc_rescan().  Why is that too late?  

Indeed, maybe the "too late" here is not accurate. Compared with host's
CD interrupt handling, the GPIO CD interrupt handling differs in when to
call sdhci_card_event(): in previous case, it's called in ISR, in later
it's in workqueue.

Now, I agree it's not necessary to put into ISR. So let's ignore the
two patches.

Thanks for your review,
Jisheng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] provide isr for card-detect interrupts Jisheng Zhang <jszhang@marvell.com> - 2017-04-11 12:30 +0200
  [PATCH 1/2] mmc: slot-gpio: check cd_gpio before setting up cd_gpio_isr Jisheng Zhang <jszhang@marvell.com> - 2017-04-11 12:30 +0200
  [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts Jisheng Zhang <jszhang@marvell.com> - 2017-04-11 12:30 +0200
    Re: [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts Adrian Hunter <adrian.hunter@intel.com> - 2017-04-11 12:40 +0200
      Re: [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts Jisheng Zhang <jszhang@marvell.com> - 2017-04-13 11:30 +0200

csiph-web