Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621528

Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files
Date 2017-04-11 20:20 +0200
Message-ID <tv8yu-27K-13@gated-at.bofh.it> (permalink)
References <tv07U-50R-3@gated-at.bofh.it> <tv07V-50R-37@gated-at.bofh.it> <tv4Ey-823-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-04-11 at 16:09 +0200, Greg Kroah-Hartman wrote:
> Care to use "real" kernel variable types please?  u8, u16, and others
> are you friend, uint8_t really isn't what we prefer, and checkpatch
> should tell you that...

checkpatch doesn't warn about "u?int\d+_t" types unless
--strict is enabled and most likely it shouldn't.

There are about 100k uses of those types in the kernel.

Many are uapi and are perhaps properly used in drivers and lib.

checkpatch can't tell what type a particular use should have.

Maybe coccinelle could based on whether the include comes
from a uapi directory or prototype or some such.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Google VPD sysfs driver Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 11:20 +0200
  [PATCH 2/2] firmware: Google VPD sysfs driver Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 11:20 +0200
  [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 11:20 +0200
    Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 16:10 +0200
      Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 16:30 +0200
      Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Joe Perches <joe@perches.com> - 2017-04-11 20:20 +0200
        Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 20:50 +0200
          Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Joe Perches <joe@perches.com> - 2017-04-11 21:00 +0200
    Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 16:20 +0200
      Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 16:20 +0200
        Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 16:40 +0200

csiph-web