Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621358
| From | Thierry Escande <thierry.escande@collabora.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files |
| Date | 2017-04-11 16:30 +0200 |
| Message-ID | <tv4XV-8aE-31@gated-at.bofh.it> (permalink) |
| References | <tv07U-50R-3@gated-at.bofh.it> <tv07V-50R-37@gated-at.bofh.it> <tv4Ey-823-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Greg
On 11/04/2017 16:09, Greg Kroah-Hartman wrote:
> On Tue, Apr 11, 2017 at 11:14:30AM +0200, Thierry Escande wrote:
>> +#include <linux/export.h>
>> +
>> +#include "vpd_decode.h"
>> +
>> +static int decode_len(const int32_t max_len, const uint8_t *in,
>> + int32_t *length, int32_t *decoded_len)
>> +{
>> + uint8_t more;
>
> Care to use "real" kernel variable types please? u8, u16, and others
> are you friend, uint8_t really isn't what we prefer, and checkpatch
> should tell you that...
By default checkpatch doesn't warn about types unless --strict is
specified... Sorry about that.
Regards,
Thierry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] Google VPD sysfs driver Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 11:20 +0200
[PATCH 2/2] firmware: Google VPD sysfs driver Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 11:20 +0200
[PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 11:20 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 16:10 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 16:30 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Joe Perches <joe@perches.com> - 2017-04-11 20:20 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 20:50 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Joe Perches <joe@perches.com> - 2017-04-11 21:00 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 16:20 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-11 16:20 +0200
Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande <thierry.escande@collabora.com> - 2017-04-11 16:40 +0200
csiph-web