Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
Date	Tue, 11 Apr 2017 17:30:02 +0200
Message-ID	<tv5TY-km-15@gated-at.bofh.it> (permalink)
References	<tuRHj-81J-1@gated-at.bofh.it> <tuYz8-3XH-23@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.0 (2017-02-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Felipe Balbi <felipe.balbi@linux.intel.com>, Marcel Partap <mpartap@gmx.net>, Michael Scott <michael.scott@linaro.org>, Sebastian Reichel <sre@kernel.org>
X-Original-Date	Tue, 11 Apr 2017 08:18:49 -0700
X-Original-Message-ID	<20170411151849.GI5339@atomide.com>
X-Original-References	<20170411001543.1338-1-tony@atomide.com> <4cd82ba4-435e-cffa-d152-98860716f38b@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1621408

Show key headers only | View raw

* Roger Quadros <rogerq@ti.com> [170411 00:31]:
> Hi Tony,
> 
> On 11/04/17 03:15, Tony Lindgren wrote:
> > Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> > added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> > bit the wrong way. The comments in the code are mostly correct, but the
> > inverted use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register
> > to be enabled instead of disabled like the comments say. And the
> > idle mode should be only disabled for UTMIAUTOIDLE while ULPIAUTOIDLE
> > can be enabled.
> > 
> > This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> > in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4.
> > Without this patch the modem can only be pinged few times before it
> > stops responding. Also lsub -v output shows errors without this patch.
> 
> This patch does 2 things.
> - Fixes the bad commit by correctly disabling Bitstuffing
> - Enables ULPI Autoidle.
> 
> Is enabling ULPI autoidle required to fix the LTE modem issue? If not I'd put it
> in a separate patch.

No but it presumably saves some power. I'll resend as to patches.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-11 02:20 +0200
  Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Roger Quadros <rogerq@ti.com> - 2017-04-11 09:40 +0200
    Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-11 17:30 +0200

csiph-web