Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621408

Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

Show all headers | View raw

* Roger Quadros <rogerq@ti.com> [170411 00:31]:
> Hi Tony,
> 
> On 11/04/17 03:15, Tony Lindgren wrote:
> > Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> > added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> > bit the wrong way. The comments in the code are mostly correct, but the
> > inverted use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register
> > to be enabled instead of disabled like the comments say. And the
> > idle mode should be only disabled for UTMIAUTOIDLE while ULPIAUTOIDLE
> > can be enabled.
> > 
> > This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> > in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4.
> > Without this patch the modem can only be pinged few times before it
> > stops responding. Also lsub -v output shows errors without this patch.
> 
> This patch does 2 things.
> - Fixes the bad commit by correctly disabling Bitstuffing
> - Enables ULPI Autoidle.
> 
> Is enabling ULPI autoidle required to fix the LTE modem issue? If not I'd put it
> in a separate patch.

No but it presumably saves some power. I'll resend as to patches.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-11 02:20 +0200
  Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Roger Quadros <rogerq@ti.com> - 2017-04-11 09:40 +0200
    Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren <tony@atomide.com> - 2017-04-11 17:30 +0200

csiph-web