Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621409

Re: [PATCH v5] lightnvn: pblk

Show key headers only | View raw

On Tue, 2017-04-11 at 16:31 +0200, Javier González wrote:
> Changes since v4:
> * Rebase on top of Matias' for-4.12/core
> * Fix type implicit conversions reported by sparse (reported by Bart Van
>   Assche)
> * Make error and debug statistics long atomic variables.

Hello Javier,

Thanks for the quick respin. But have you already had a look at the
diagnostics reported by smatch? Smatch reports e.g.

drivers/lightnvm/pblk-rb.c:783: pblk_rb_tear_down_check() error: we previously assumed 'rb->entries' could be null (see line 779)

on the following code:

	if (rb->entries)
		goto out;

	for (i = 0; i < rb->nr_entries; i++) {
		entry = &rb->entries[i];

		if (entry->data)
			goto out;
	}

Is that "if (rb->entries)" check correct or should that perhaps been
"if (!rb->entries)"? Smatch is available at http://repo.or.cz/w/smatch.git.

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] lightnvn: pblk "Javier González" <jg@lightnvm.io> - 2017-04-11 16:40 +0200
  Re: [PATCH v5] lightnvm: physical block device (pblk) target Matias Bjørling <mb@lightnvm.io> - 2017-04-11 16:50 +0200
  Re: [PATCH v5] lightnvn: pblk Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-04-11 17:30 +0200
    Re: [PATCH v5] lightnvn: pblk Javier González <jg@lightnvm.io> - 2017-04-12 00:20 +0200
      Re: [PATCH v5] lightnvn: pblk Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-04-12 00:30 +0200
        Re: [PATCH v5] lightnvn: pblk Javier González <jg@lightnvm.io> - 2017-04-12 10:10 +0200

csiph-web