Re: [PATCH] um: use KERN_CONT in stack dump

From	Vegard Nossum <vegard.nossum@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] um: use KERN_CONT in stack dump
Date	2017-04-11 11:40 +0200
Message-ID	<tv0rg-57u-11@gated-at.bofh.it> (permalink)
References	<tk88O-7Y2-13@gated-at.bofh.it> <tk8it-81C-5@gated-at.bofh.it> <tk8it-81C-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12 March 2017 at 10:47, Vegard Nossum <vegard.nossum@oracle.com> wrote:
> On 12/03/2017 10:45, Richard Weinberger wrote:
>> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
>> index aa1b56f5ac68..18eddf677ec6 100644
>> --- a/arch/um/kernel/sysrq.c
>> +++ b/arch/um/kernel/sysrq.c
>> @@ -17,10 +17,8 @@
>>
>>  static void _print_addr(void *data, unsigned long address, int reliable)
>>  {
>> -       pr_info(" [<%08lx>]", address);
>> -       pr_cont(" %s", reliable ? "" : "? ");
>> -       print_symbol("%s", address);
>> -       pr_cont("\n");
>> +       pr_info(" [<%08lx>] %s%pB\n", address, reliable ? "" : "? ",
>> +               (void *)address);
>>  }
>
> Tested-by: Vegard Nossum <vegard.nossum@oracle.com>

Just a heads up, this still appears unfixed in Linus's repo.


Vegard

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] um: use KERN_CONT in stack dump Vegard Nossum <vegard.nossum@gmail.com> - 2017-04-11 11:40 +0200

csiph-web