Groups > linux.kernel > #1620754

Re: [PATCH v3] ia64: fix module loading for gcc-5.4+

From	Sergei Trofimovich <slyfox@gentoo.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] ia64: fix module loading for gcc-5.4+
Date	2017-04-11 00:00 +0200
Message-ID	<tuPvP-6qR-9@gated-at.bofh.it> (permalink)
References	<tu4GB-1ac-11@gated-at.bofh.it> <tu4GB-1ac-9@gated-at.bofh.it> <tuLiz-3MR-55@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 10 Apr 2017 19:23:28 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> > -	if (slot(insn) != 2) {
> > +	if (slot(insn) != 1 && slot(insn) != 2) {  
> 
> +	int const s = slot(insn);
> +	if (s < 1 || s > 2) {
> 
> Do run time characteristics matter for such a condition check here?

It's done once at kernel module load time. My guess would be
"not critical at all".

slot() is a pure arithmetic static inline function. You can compare
assembly output before and after your change.

You can measure the difference yourself using 'ski' emulator.
That's for example how I debugged and tested the patch:
     http://trofi.github.io/posts/199-ia64-machine-emulation.html

-- 

  Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] ia64: fix module loading for gcc-5.4+ SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-10 19:30 +0200
  Re: [PATCH v3] ia64: fix module loading for gcc-5.4+ Sergei Trofimovich <slyfox@gentoo.org> - 2017-04-11 00:00 +0200

csiph-web