Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1620459
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] ia64: fix module loading for gcc-5.4+ |
| Date | 2017-04-10 19:30 +0200 |
| Message-ID | <tuLiz-3MR-55@gated-at.bofh.it> (permalink) |
| References | <tu4GB-1ac-11@gated-at.bofh.it> <tu4GB-1ac-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> +++ b/arch/ia64/kernel/module.c
> @@ -153,7 +153,7 @@ slot (const struct insn *insn)
> static int
> apply_imm64 (struct module *mod, struct insn *insn, uint64_t val)
> {
I have got another idea (after your clarification) for the suggested change.
> - if (slot(insn) != 2) {
> + if (slot(insn) != 1 && slot(insn) != 2) {
+ int const s = slot(insn);
+ if (s < 1 || s > 2) {
Do run time characteristics matter for such a condition check here?
> printk(KERN_ERR "%s: invalid slot number %d for IMM64\n",
- mod->name, slot(insn));
+ mod->name, s);
> return 0;
How do you think about my update suggestion for this function implementation?
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] ia64: fix module loading for gcc-5.4 Sergei Trofimovich <slyfox@gentoo.org> - 2017-04-08 22:00 +0200
Re: [PATCH v3] ia64: fix module loading for gcc-5.4 SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-09 10:30 +0200
Re: [PATCH v3] ia64: fix module loading for gcc-5.4 Sergei Trofimovich <slyfox@gentoo.org> - 2017-04-09 11:00 +0200
Re: ia64: fix module loading for gcc-5.4 SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-09 11:10 +0200
Re: ia64: fix module loading for gcc-5.4 Sergei Trofimovich <slyfox@gentoo.org> - 2017-04-09 12:40 +0200
Re: [PATCH v3] ia64: fix module loading for gcc-5.4+ SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-10 19:30 +0200
Re: [PATCH v3] ia64: fix module loading for gcc-5.4+ Sergei Trofimovich <slyfox@gentoo.org> - 2017-04-11 00:00 +0200
csiph-web