Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1620004

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH -v2 0/9] mm: make movable onlining suck less
Date 2017-04-10 17:00 +0200
Message-ID <tuIXo-21C-29@gated-at.bofh.it> (permalink)
References <tuFmO-8iD-7@gated-at.bofh.it> <tuIum-1Rg-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon 10-04-17 16:27:49, Igor Mammedov wrote:
[...]
> Hi Michal,
> 
> I've given series some dumb testing, see below for unexpected changes I've noticed.
> 
> Using the same CLI as above plus hotpluggable dimms present at startup
> (it still uses hotplug path as dimms aren't reported in e820)
> 
> -object memory-backend-ram,id=mem1,size=256M -object memory-backend-ram,id=mem0,size=256M \
> -device pc-dimm,id=dimm1,memdev=mem1,slot=1,node=0 -device pc-dimm,id=dimm0,memdev=mem0,slot=0,node=0
> 
> so dimm1 => memory3[23] and dimm0 => memory3[45]
> 
> #issue1:
> unable to online memblock as NORMAL adjacent to onlined MOVABLE
> 
> 1: after boot
> memory32:offline removable: 0  zones: Normal Movable
> memory33:offline removable: 0  zones: Normal Movable
> memory34:offline removable: 0  zones: Normal Movable
> memory35:offline removable: 0  zones: Normal Movable
> 
> 2: online as movable 1st dimm
> 
> #echo online_movable > memory32/state
> #echo online_movable > memory33/state
> 
> everything is as expected:
> memory32:online removable: 1  zones: Movable
> memory33:online removable: 1  zones: Movable
> memory34:offline removable: 0  zones: Movable
> memory35:offline removable: 0  zones: Movable
> 
> 3: try to offline memory32 and online as NORMAL
> 
> #echo offline > memory32/state
> memory32:offline removable: 1  zones: Normal Movable
> memory33:online removable: 1  zones: Movable
> memory34:offline removable: 0  zones: Movable
> memory35:offline removable: 0  zones: Movable

OK, this is not expected. We are not shifting zones anymore so the range
which was online_movable will not become available to the zone Normal.
So this must be something broken down the show_valid_zones path. I will
investigate.

> 
> #echo online_kernel > memory32/state
> write error: Invalid argument
> // that's not what's expected

this is proper behavior with the current implementation. Does anything
depend on the zone reusing?

> memory32:offline removable: 1  zones: Normal Movable
> memory33:online removable: 1  zones: Movable
> memory34:offline removable: 0  zones: Movable
> memory35:offline removable: 0  zones: Movable
> 
> 
> ======
> #issue2: dimm1 assigned to node 1 on qemu CLI
> memblock is onlined as movable by default
> 
> // after boot
> memory32:offline removable: 1  zones: Normal
> memory33:offline removable: 1  zones: Normal Movable
> memory34:offline removable: 1  zones: Normal
> memory35:offline removable: 1  zones: Normal Movable
> // not related to this issue but notice not all blocks are
> // "Normal Movable" when compared when both dimms on node 0 /#issue1/

yes they should be

> #echo online_movable > memory33/state
> #echo online > memory32/state
> 
> memory32:online removable: 1  zones: Movable
> memory33:online removable: 1  zones: Movable
> 
> before series memory32 goes to zone NORMAL as expected
> memory32:online removable: 0  zones: Normal Movable
> memory33:online removable: 1  zones: Movable Normal

OK, I will double check.
 
> ======
> #issue3:
> removable flag flipped to non-removable state
> 
> // before series at commit ef0b577b6:
> memory32:offline removable: 0  zones: Normal Movable
> memory33:offline removable: 0  zones: Normal Movable
> memory34:offline removable: 0  zones: Normal Movable
> memory35:offline removable: 0  zones: Normal Movable
> 
> // after series at commit 6a010434
> memory32:offline removable: 1  zones: Normal
> memory33:offline removable: 1  zones: Normal
> memory34:offline removable: 1  zones: Normal
> memory35:offline removable: 1  zones: Normal Movable
> 
> also looking at #issue1 removable flag state doesn't
> seem to be consistent between state changes but maybe that's
> been broken before

OK, will have a look.

Thanks for your testing!

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 13:10 +0200
  [PATCH 3/9] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko <mhocko@kernel.org> - 2017-04-10 13:10 +0200
    Re: [PATCH 3/9] mm: drop page_initialized check from get_nid_for_pfn Vlastimil Babka <vbabka@suse.cz> - 2017-04-13 15:00 +0200
  [PATCH 9/9] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko <mhocko@kernel.org> - 2017-04-10 13:10 +0200
    Re: [PATCH 9/9] mm, memory_hotplug: remove unused cruft after memory  hotplug rework Vlastimil Babka <vbabka@suse.cz> - 2017-04-20 10:40 +0200
  [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-04-10 13:10 +0200
    Re: [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Jerome Glisse <jglisse@redhat.com> - 2017-04-10 18:30 +0200
      Re: [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-04-10 18:40 +0200
    Re: [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Vlastimil Babka <vbabka@suse.cz> - 2017-04-13 15:10 +0200
    Re: [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Jerome Glisse <jglisse@redhat.com> - 2017-04-17 22:20 +0200
      Re: [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-04-18 09:20 +0200
  [PATCH 5/9] mm, memory_hotplug: split up register_one_node Michal Hocko <mhocko@kernel.org> - 2017-04-10 13:10 +0200
    Re: [PATCH 5/9] mm, memory_hotplug: split up register_one_node Vlastimil Babka <vbabka@suse.cz> - 2017-04-13 16:10 +0200
      Re: [PATCH 5/9] mm, memory_hotplug: split up register_one_node Michal Hocko <mhocko@kernel.org> - 2017-04-13 16:20 +0200
  Re: [PATCH -v2 0/9] mm: make movable onlining suck less Igor Mammedov <imammedo@redhat.com> - 2017-04-10 16:30 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 17:00 +0200
      Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 17:30 +0200
        Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 17:40 +0200
      Re: [PATCH -v2 0/9] mm: make movable onlining suck less Igor Mammedov <imammedo@redhat.com> - 2017-04-11 10:10 +0200
        Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 10:50 +0200
          Re: [PATCH -v2 0/9] mm: make movable onlining suck less Igor Mammedov <imammedo@redhat.com> - 2017-04-11 12:00 +0200
            Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 12:50 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 18:10 +0200
      Re: [PATCH -v2 0/9] mm: make movable onlining suck less Vlastimil Babka <vbabka@suse.cz> - 2017-04-18 10:30 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 18:10 +0200
      Re: [PATCH -v2 0/9] mm: make movable onlining suck less Igor Mammedov <imammedo@redhat.com> - 2017-04-11 08:40 +0200
        Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 11:30 +0200
          Re: [PATCH -v2 0/9] mm: make movable onlining suck less Igor Mammedov <imammedo@redhat.com> - 2017-04-11 12:00 +0200
            Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 13:10 +0200
              Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 13:40 +0200
                Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 14:40 +0200
  Re: [PATCH -v2 0/9] mm: make movable onlining suck less Reza Arbab <arbab@linux.vnet.ibm.com> - 2017-04-10 17:50 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 11:00 +0200
  Re: [PATCH -v2 0/9] mm: make movable onlining suck less Jerome Glisse <jglisse@redhat.com> - 2017-04-10 18:40 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-10 20:00 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Balbir Singh <bsingharora@gmail.com> - 2017-04-11 05:00 +0200
  Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 19:10 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Dan Williams <dan.j.williams@gmail.com> - 2017-04-18 00:00 +0200
      Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-18 09:20 +0200
        Re: [PATCH -v2 0/9] mm: make movable onlining suck less Dan Williams <dan.j.williams@gmail.com> - 2017-04-18 18:50 +0200
          Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-18 22:00 +0200
            Re: [PATCH -v2 0/9] mm: make movable onlining suck less Dan Williams <dan.j.williams@intel.com> - 2017-04-20 05:40 +0200
  [PATCH 3/3] mm: __first_valid_page skip over offline pages Michal Hocko <mhocko@kernel.org> - 2017-04-15 14:20 +0200
  [PATCH 1/3] mm: consider zone which is not fully populated to have holes Michal Hocko <mhocko@kernel.org> - 2017-04-15 14:20 +0200
    Re: [PATCH 1/3] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-04-18 10:50 +0200
      Re: [PATCH 1/3] mm: consider zone which is not fully populated to  have holes Michal Hocko <mhocko@kernel.org> - 2017-04-18 11:30 +0200
        Re: [PATCH 1/3] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-04-19 14:00 +0200
          Re: [PATCH 1/3] mm: consider zone which is not fully populated to  have holes Michal Hocko <mhocko@kernel.org> - 2017-04-19 14:20 +0200
            Re: [PATCH 1/3] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-04-19 14:40 +0200
              Re: [PATCH 1/3] mm: consider zone which is not fully populated to  have holes Michal Hocko <mhocko@kernel.org> - 2017-04-19 15:00 +0200
  (none) Michal Hocko <mhocko@kernel.org> - 2017-04-15 14:20 +0200
    [PATCH 2/3] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko <mhocko@kernel.org> - 2017-04-15 14:20 +0200
    Re: your mail Joonsoo Kim <js1304@gmail.com> - 2017-04-17 07:50 +0200
      Re: your mail Michal Hocko <mhocko@kernel.org> - 2017-04-17 10:20 +0200
        Re: your mail Joonsoo Kim <js1304@gmail.com> - 2017-04-20 03:30 +0200
          Re: your mail Michal Hocko <mhocko@kernel.org> - 2017-04-20 09:30 +0200
            Re: your mail Michal Hocko <mhocko@kernel.org> - 2017-04-20 10:50 +0200
              Re: your mail Vlastimil Babka <vbabka@suse.cz> - 2017-04-20 14:00 +0200
                Re: your mail Michal Hocko <mhocko@kernel.org> - 2017-04-20 14:20 +0200
            Re: your mail Joonsoo Kim <js1304@gmail.com> - 2017-04-21 06:40 +0200
              Re: your mail Michal Hocko <mhocko@kernel.org> - 2017-04-21 09:20 +0200
                Re: your mail Joonsoo Kim <js1304@gmail.com> - 2017-04-24 03:50 +0200
                Re: your mail Michal Hocko <mhocko@kernel.org> - 2017-04-24 10:00 +0200

csiph-web