Re: [PATCH 3/9] mm: drop page_initialized check from get_nid_for_pfn

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] mm: drop page_initialized check from get_nid_for_pfn
Date	2017-04-13 15:00 +0200
Message-ID	<tvMvU-388-9@gated-at.bofh.it> (permalink)
References	<tuFmO-8iD-7@gated-at.bofh.it> <tuFmP-8iD-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/10/2017 01:03 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
> 
> c04fc586c1a4 ("mm: show node to memory section relationship with
> symlinks in sysfs") has added means to export memblock<->node
> association into the sysfs. It has also introduced get_nid_for_pfn
> which is a rather confusing counterpart of pfn_to_nid which checks also
> whether the pfn page is already initialized (page_initialized).  This
> is done by checking page::lru != NULL which doesn't make any sense at
> all. Nothing in this path really relies on the lru list being used or
> initialized. Just remove it because this will become a problem with
> later patches.
> 
> Thanks to Reza Arbab for testing which revealed this to be a problem
> (http://lkml.kernel.org/r/20170403202337.GA12482@dhcp22.suse.cz)
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/9] mm: drop page_initialized check from get_nid_for_pfn Vlastimil Babka <vbabka@suse.cz> - 2017-04-13 15:00 +0200

csiph-web