Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619761
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv3] x86/intel_rdt: Add cpus_list rdtgroup file |
| Date | 2017-04-10 11:50 +0200 |
| Message-ID | <tuE7n-7nn-7@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <tr0SS-2Gc-17@gated-at.bofh.it> <tr77X-6xs-7@gated-at.bofh.it> <tuoch-5nt-1@gated-at.bofh.it> <tuoYF-60j-1@gated-at.bofh.it> <tuCff-6dm-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 10 Apr 2017, Jiri Olsa wrote:
> /* List of all resource groups */
> extern struct list_head rdt_all_groups;
>
> @@ -56,6 +59,7 @@ struct rftype {
> char *name;
> umode_t mode;
> struct kernfs_ops *kf_ops;
> + unsigned long flags;
Lacks update in the kernel-doc comment.
> @@ -182,9 +189,10 @@ static int rdtgroup_cpus_show(struct kernfs_open_file *of,
>
> rdtgrp = rdtgroup_kn_lock_live(of->kn);
>
> - if (rdtgrp)
> - seq_printf(s, "%*pb\n", cpumask_pr_args(&rdtgrp->cpu_mask));
> - else
> + if (rdtgrp) {
> + seq_printf(s, is_list(of) ? "%*pbl\n" : "%*pb\n",
> + cpumask_pr_args(&rdtgrp->cpu_mask));
> + } else
> ret = -ENOENT;
This lacks braces around the else path
> @@ -473,6 +485,14 @@ static int rdtgroup_tasks_show(struct kernfs_open_file *of,
> .seq_show = rdtgroup_cpus_show,
> },
> {
> + .name = "cpus_list",
> + .mode = 0644,
> + .kf_ops = &rdtgroup_kf_single_ops,
> + .write = rdtgroup_cpus_write,
> + .seq_show = rdtgroup_cpus_show,
> + .flags = RFTYPE_FLAGS_CPUS_LIST,
> + },
Please add the new file to Documentation/x86/intel_rdt_ui.txt
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@kernel.org> - 2017-03-29 17:20 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Fenghua Yu <fenghua.yu@intel.com> - 2017-03-29 18:10 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@redhat.com> - 2017-03-29 18:20 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@redhat.com> - 2017-03-30 17:10 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Fenghua Yu <fenghua.yu@intel.com> - 2017-04-01 04:00 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Thomas Gleixner <tglx@linutronix.de> - 2017-03-31 10:50 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Fenghua Yu <fenghua.yu@intel.com> - 2017-03-31 18:00 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Thomas Gleixner <tglx@linutronix.de> - 2017-03-31 11:20 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Fenghua Yu <fenghua.yu@intel.com> - 2017-03-31 17:40 +0200
Re: [PATCH] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@redhat.com> - 2017-03-31 18:00 +0200
[PATCHv2] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@redhat.com> - 2017-04-09 18:50 +0200
Re: [PATCHv2] x86/intel_rdt: Add cpus_list rdtgroup file Fenghua Yu <fenghua.yu@intel.com> - 2017-04-09 19:40 +0200
[PATCHv3] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@redhat.com> - 2017-04-10 09:50 +0200
Re: [PATCHv3] x86/intel_rdt: Add cpus_list rdtgroup file Thomas Gleixner <tglx@linutronix.de> - 2017-04-10 11:50 +0200
[PATCHv4] x86/intel_rdt: Add cpus_list rdtgroup file Jiri Olsa <jolsa@redhat.com> - 2017-04-10 17:00 +0200
[tip:x86/cpu] x86/intel_rdt: Add cpus_list rdtgroup file tip-bot for Jiri Olsa <tipbot@zytor.com> - 2017-04-10 19:30 +0200
Re: [PATCHv2] x86/intel_rdt: Add cpus_list rdtgroup file Thomas Gleixner <tglx@linutronix.de> - 2017-04-10 11:20 +0200
csiph-web